Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit cf94bc09 authored by Daniel Kurtz's avatar Daniel Kurtz Committed by Henrik Rydberg
Browse files

Input: atmel_mxt_ts - optimize writing of object table entries 



Write each object using a single bulk i2c write transfer.

Signed-off-by: default avatarDaniel Kurtz <djkurtz@chromium.org>
Reviewed-by: default avatarJoonyoung Shim <jy0922.shim@samsung.com>
Signed-off-by: default avatarHenrik Rydberg <rydberg@euromail.se>
parent 9638ab7c

drivers/input/touchscreen/atmel_mxt_ts.c

+12 −12
Original line number Diff line number Diff line
@@ -655,7 +655,8 @@ static int mxt_check_reg_init(struct mxt_data *data) 
	struct mxt_object *object;

	struct device *dev = &data->client->dev;

	int index = 0;

	int i, j, config_offset;

	int i, size;

	int ret;



	if (!pdata->config) {

		dev_dbg(dev, "No cfg data defined, skipping reg init\n");
@@ -668,18 +669,17 @@ static int mxt_check_reg_init(struct mxt_data *data) 
		if (!mxt_object_writable(object->type))

			continue;



		for (j = 0;

		     j < (object->size + 1) * (object->instances + 1);

		     j++) {

			config_offset = index + j;

			if (config_offset > pdata->config_length) {

		size = (object->size + 1) * (object->instances + 1);

		if (index + size > pdata->config_length) {

			dev_err(dev, "Not enough config data!\n");

			return -EINVAL;

		}

			mxt_write_object(data, object->type, j,

					 pdata->config[config_offset]);

		}

		index += (object->size + 1) * (object->instances + 1);



		ret = __mxt_write_reg(data->client, object->start_address,

				size, &pdata->config[index]);

		if (ret)

			return ret;

		index += size;

	}



	return 0;