Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit cb4b102f authored by Dan Carpenter's avatar Dan Carpenter Committed by David S. Miller
Browse files

tipc: add a bounds check in link_recv_changeover_msg() 



The bearer_id here comes from skb->data and it can be a number from 0 to
7.  The problem is that the ->links[] array has only 2 elements so I
have added a range check.

Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent ac718b69

net/tipc/link.c

+4 −1
Original line number Diff line number Diff line
@@ -2306,8 +2306,11 @@ static int link_recv_changeover_msg(struct tipc_link **l_ptr, 
	struct tipc_msg *tunnel_msg = buf_msg(tunnel_buf);

	u32 msg_typ = msg_type(tunnel_msg);

	u32 msg_count = msg_msgcnt(tunnel_msg);

	u32 bearer_id = msg_bearer_id(tunnel_msg);



	dest_link = (*l_ptr)->owner->links[msg_bearer_id(tunnel_msg)];

	if (bearer_id >= MAX_BEARERS)

		goto exit;

	dest_link = (*l_ptr)->owner->links[bearer_id];

	if (!dest_link)

		goto exit;

	if (dest_link == *l_ptr) {