Commit cb354842 authored Sep 02, 2014 by Joern Engel Committed by Nicholas Bellinger Sep 17, 2014

iscsi-target: remove always-true conditions



Found by coverity.  InitiatorName and InitiatorAlias are static arrays
and therefore always non-NULL.  At some point in the past they may have
been dynamically allocated, but for current code the condition is
useless.  If the intent was to check InitiatorName[0] instead, I cannot
find a use for that either.  Let's get rid of it.

Signed-off-by: Joern Engel <joern@logfs.org>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>

parent fbecb659

drivers/target/iscsi/iscsi_target_configfs.c

+4 −6

Original line number	Diff line number	Diff line
		@@ -669,10 +669,8 @@ static ssize_t lio_target_nacl_show_info(
		} else {
		sess = se_sess->fabric_sess_ptr;

		if (sess->sess_ops->InitiatorName)
		rb += sprintf(page+rb, "InitiatorName: %s\n",
		sess->sess_ops->InitiatorName);
		if (sess->sess_ops->InitiatorAlias)
		rb += sprintf(page+rb, "InitiatorAlias: %s\n",
		sess->sess_ops->InitiatorAlias);