Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c9ca319f authored by Viresh Kumar's avatar Viresh Kumar Committed by Eduardo Valentin
Browse files

thermal: cpu_cooling: Don't check is_cpufreq_valid() 



Because get_cpu_frequency() has returned a valid frequency, it means that the
cpufreq policy is surely valid and so no point checking that again with
is_cpufreq_valid(). Get rid of the routine as well as there are no more users.

Signed-off-by: default avatarViresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: default avatarEduardo Valentin <edubezval@gmail.com>
parent e1fae554

drivers/thermal/cpu_cooling.c

+1 −19
Original line number Diff line number Diff line
@@ -110,23 +110,6 @@ static void release_idr(struct idr *idr, int id) 


/* Below code defines functions to be used for cpufreq as cooling device */



/**

 * is_cpufreq_valid - function to check frequency transitioning capability.

 * @cpu: cpu for which check is needed.

 *

 * This function will check the current state of the system if

 * it is capable of changing the frequency for a given @cpu.

 *

 * Return: 0 if the system is not currently capable of changing

 * the frequency of given cpu. !0 in case the frequency is changeable.

 */

static int is_cpufreq_valid(int cpu)

{

	struct cpufreq_policy policy;



	return !cpufreq_get_policy(&policy, cpu);

}



enum cpufreq_cooling_property {

	GET_LEVEL,

	GET_FREQ,
@@ -300,7 +283,6 @@ static int cpufreq_apply_cooling(struct cpufreq_cooling_device *cpufreq_device, 
	cpufreq_device->cpufreq_state = cooling_state;

	cpufreq_device->cpufreq_val = clip_freq;



	if (is_cpufreq_valid(cpu))

	cpufreq_update_policy(cpu);



	return 0;