Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c82c6b15 authored by Chao Yu's avatar Chao Yu Committed by Jaegeuk Kim
Browse files

f2fs: record inode updating status correctly 



commit 60dcedc9972d136fab1600c919dd32080bcc26f7 upstream.

We should record updating status of inode only for living inode, for those
unlinked inode it needs to clear its ino cache, otherwise after the ino
was been reused, it will cause unneeded node page writing during ->fsync.

Signed-off-by: default avatarChao Yu <yuchao0@huawei.com>
Signed-off-by: default avatarJaegeuk Kim <jaegeuk@kernel.org>
parent e9647629

fs/f2fs/inode.c

+9 −4
Original line number Diff line number Diff line
@@ -377,6 +377,9 @@ void f2fs_evict_inode(struct inode *inode) 
		goto no_delete;

#endif



	remove_ino_entry(sbi, inode->i_ino, APPEND_INO);

	remove_ino_entry(sbi, inode->i_ino, UPDATE_INO);



	sb_start_intwrite(inode->i_sb);

	set_inode_flag(inode, FI_NO_ALLOC);

	i_size_write(inode, 0);
@@ -409,10 +412,12 @@ no_delete: 
	invalidate_mapping_pages(NODE_MAPPING(sbi), inode->i_ino, inode->i_ino);

	if (xnid)

		invalidate_mapping_pages(NODE_MAPPING(sbi), xnid, xnid);

	if (inode->i_nlink) {

		if (is_inode_flag_set(inode, FI_APPEND_WRITE))

			add_ino_entry(sbi, inode->i_ino, APPEND_INO);

		if (is_inode_flag_set(inode, FI_UPDATE_WRITE))

			add_ino_entry(sbi, inode->i_ino, UPDATE_INO);

	}

	if (is_inode_flag_set(inode, FI_FREE_NID)) {

		alloc_nid_failed(sbi, inode->i_ino);

		clear_inode_flag(inode, FI_FREE_NID);