Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c7557e6a authored by Dan Carpenter's avatar Dan Carpenter Committed by David S. Miller
Browse files

amd-xgbe: fix a couple timeout loops 



At the end of the loop we test "if (!count)" but because "count--" is
a post-op then the loop will end with count set to -1.  I have fixed
this by changing it to --count.

Fixes: c5aa9e3b ('amd-xgbe: Initial AMD 10GbE platform driver')
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 40d24c4d

drivers/net/ethernet/amd/xgbe/xgbe-dev.c

+2 −2
Original line number Diff line number Diff line
@@ -1849,7 +1849,7 @@ static int xgbe_exit(struct xgbe_prv_data *pdata) 
	usleep_range(10, 15);



	/* Poll Until Poll Condition */

	while (count-- && XGMAC_IOREAD_BITS(pdata, DMA_MR, SWR))

	while (--count && XGMAC_IOREAD_BITS(pdata, DMA_MR, SWR))

		usleep_range(500, 600);



	if (!count)
@@ -1873,7 +1873,7 @@ static int xgbe_flush_tx_queues(struct xgbe_prv_data *pdata) 
	/* Poll Until Poll Condition */

	for (i = 0; i < pdata->tx_q_count; i++) {

		count = 2000;

		while (count-- && XGMAC_MTL_IOREAD_BITS(pdata, i,

		while (--count && XGMAC_MTL_IOREAD_BITS(pdata, i,

							MTL_Q_TQOMR, FTQ))

			usleep_range(500, 600);