Commit c72c5250 authored Jul 22, 2015 by Roland Dreier Committed by Nicholas Bellinger Jul 30, 2015

target: allow underflow/overflow for PR OUT etc. commands



It's not necessarily a fatal error if a command with a data-out phase
has a data length that differs from the transport data length (e.g.
PERSISTENT RESERVE OUT might have a parameter list length in the CDB
that's smaller than the FC_DL field), so allow these commands.  The
Windows compliance test sends them.

Signed-off-by: Roland Dreier <roland@purestorage.com>
Signed-off-by: Spencer Baugh <sbaugh@catern.com>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>

parent aa75679c

drivers/target/target_core_transport.c

+3 −3

Original line number	Diff line number	Diff line
		@@ -1088,9 +1088,9 @@ target_cmd_size_check(struct se_cmd *cmd, unsigned int size)
		" 0x%02x\n", cmd->se_tfo->get_fabric_name(),
		cmd->data_length, size, cmd->t_task_cdb[0]);

		if (cmd->data_direction == DMA_TO_DEVICE) {
		pr_err("Rejecting underflow/overflow"
		" WRITE data\n");
		if (cmd->data_direction == DMA_TO_DEVICE &&
		cmd->se_cmd_flags & SCF_SCSI_DATA_CDB) {
		pr_err("Rejecting underflow/overflow WRITE data\n");
		return TCM_INVALID_CDB_FIELD;
		}
		/*