Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c6048afa authored by Kai-Heng Feng's avatar Kai-Heng Feng Committed by Greg Kroah-Hartman
Browse files

ALSA: hda/realtek: Fix pop noise on ALC225 

commit 3b36b13d5e69d6f51ff1c55d1b404a74646c9757 upstream.

Commit 317d9313925c ("ALSA: hda/realtek - Set default power save node to
0") makes the ALC225 have pop noise on S3 resume and cold boot.

So partially revert this commit for ALC225 to fix the regression.

Fixes: 317d9313925c ("ALSA: hda/realtek - Set default power save node to 0")
BugLink: https://bugs.launchpad.net/bugs/1866357


Signed-off-by: default avatarKai-Heng Feng <kai.heng.feng@canonical.com>
Link: https://lore.kernel.org/r/20200311061328.17614-1-kai.heng.feng@canonical.com


Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 9679d496

sound/pci/hda/patch_realtek.c

+2 −0
Original line number Diff line number Diff line
@@ -6333,6 +6333,8 @@ static int patch_alc269(struct hda_codec *codec) 
		alc_update_coef_idx(codec, 0x36, 1 << 13, 1 << 5); /* Switch pcbeep path to Line in path*/

		break;

	case 0x10ec0225:

		codec->power_save_node = 1;

		/* fall through */

	case 0x10ec0295:

	case 0x10ec0299:

		spec->codec_variant = ALC269_TYPE_ALC225;