Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c5f841f1 authored by Rusty Russell's avatar Rusty Russell
Browse files

virtio: more neatening of virtio_ring macros. 



Impact: cleanup

Roel Kluin drew attention to these macros with his patch: here I
neaten them a little further:
1) Add a comment on what START_USE and END_USE are checking,
2) Brackets around _vq in BAD_RING,
3) Neaten formatting for START_USE so it's less than 80 cols.

Signed-off-by: default avatarRusty Russell <rusty@rustcorp.com.au>
parent 3a35ce7d

drivers/virtio/virtio_ring.c

+9 −3
Original line number Diff line number Diff line
@@ -24,9 +24,15 @@ 
#ifdef DEBUG

/* For development, we want to crash whenever the ring is screwed. */

#define BAD_RING(_vq, fmt...)			\

	do { dev_err(&_vq->vq.vdev->dev, fmt); BUG(); } while(0)

	do { dev_err(&(_vq)->vq.vdev->dev, fmt); BUG(); } while(0)

/* Caller is supposed to guarantee no reentry. */

#define START_USE(_vq)						\

	do { if ((_vq)->in_use) panic("in_use = %i\n", (_vq)->in_use); (_vq)->in_use = __LINE__; mb(); } while(0)

	do {							\

		if ((_vq)->in_use)				\

			panic("in_use = %i\n", (_vq)->in_use);	\

		(_vq)->in_use = __LINE__;			\

		mb();						\

	} while(0)

#define END_USE(_vq) \

	do { BUG_ON(!(_vq)->in_use); (_vq)->in_use = 0; mb(); } while(0)

#else