Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c53135d6 authored by Johan Hovold's avatar Johan Hovold Committed by Greg Kroah-Hartman
Browse files

staging: rtl8192u: fix control-message timeouts 



commit 4cfa36d312d6789448b59a7aae770ac8425017a3 upstream.

USB control-message timeouts are specified in milliseconds and should
specifically not vary with CONFIG_HZ.

Fixes: 8fc8598e ("Staging: Added Realtek rtl8192u driver to staging")
Cc: stable@vger.kernel.org      # 2.6.33
Acked-by: default avatarLarry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: default avatarJohan Hovold <johan@kernel.org>
Link: https://lore.kernel.org/r/20211025120910.6339-2-johan@kernel.org


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent dc8f5cfd

drivers/staging/rtl8192u/r8192U_core.c

+9 −9
Original line number Diff line number Diff line
@@ -267,7 +267,7 @@ void write_nic_byte_E(struct net_device *dev, int indx, u8 data) 


	status = usb_control_msg(udev, usb_sndctrlpipe(udev, 0),

				 RTL8187_REQ_SET_REGS, RTL8187_REQT_WRITE,

				 indx | 0xfe00, 0, usbdata, 1, HZ / 2);

				 indx | 0xfe00, 0, usbdata, 1, 500);

	kfree(usbdata);



	if (status < 0)
@@ -287,7 +287,7 @@ int read_nic_byte_E(struct net_device *dev, int indx, u8 *data) 


	status = usb_control_msg(udev, usb_rcvctrlpipe(udev, 0),

				 RTL8187_REQ_GET_REGS, RTL8187_REQT_READ,

				 indx | 0xfe00, 0, usbdata, 1, HZ / 2);

				 indx | 0xfe00, 0, usbdata, 1, 500);

	*data = *usbdata;

	kfree(usbdata);
@@ -314,7 +314,7 @@ void write_nic_byte(struct net_device *dev, int indx, u8 data) 
	status = usb_control_msg(udev, usb_sndctrlpipe(udev, 0),

				 RTL8187_REQ_SET_REGS, RTL8187_REQT_WRITE,

				 (indx & 0xff) | 0xff00, (indx >> 8) & 0x0f,

				 usbdata, 1, HZ / 2);

				 usbdata, 1, 500);

	kfree(usbdata);



	if (status < 0)
@@ -340,7 +340,7 @@ void write_nic_word(struct net_device *dev, int indx, u16 data) 
	status = usb_control_msg(udev, usb_sndctrlpipe(udev, 0),

				 RTL8187_REQ_SET_REGS, RTL8187_REQT_WRITE,

				 (indx & 0xff) | 0xff00, (indx >> 8) & 0x0f,

				 usbdata, 2, HZ / 2);

				 usbdata, 2, 500);

	kfree(usbdata);



	if (status < 0)
@@ -365,7 +365,7 @@ void write_nic_dword(struct net_device *dev, int indx, u32 data) 
	status = usb_control_msg(udev, usb_sndctrlpipe(udev, 0),

				 RTL8187_REQ_SET_REGS, RTL8187_REQT_WRITE,

				 (indx & 0xff) | 0xff00, (indx >> 8) & 0x0f,

				 usbdata, 4, HZ / 2);

				 usbdata, 4, 500);

	kfree(usbdata);
@@ -390,7 +390,7 @@ int read_nic_byte(struct net_device *dev, int indx, u8 *data) 
	status = usb_control_msg(udev, usb_rcvctrlpipe(udev, 0),

				 RTL8187_REQ_GET_REGS, RTL8187_REQT_READ,

				 (indx & 0xff) | 0xff00, (indx >> 8) & 0x0f,

				 usbdata, 1, HZ / 2);

				 usbdata, 1, 500);

	*data = *usbdata;

	kfree(usbdata);
@@ -417,7 +417,7 @@ int read_nic_word(struct net_device *dev, int indx, u16 *data) 
	status = usb_control_msg(udev, usb_rcvctrlpipe(udev, 0),

				 RTL8187_REQ_GET_REGS, RTL8187_REQT_READ,

				 (indx & 0xff) | 0xff00, (indx >> 8) & 0x0f,

				 usbdata, 2, HZ / 2);

				 usbdata, 2, 500);

	*data = *usbdata;

	kfree(usbdata);
@@ -441,7 +441,7 @@ static int read_nic_word_E(struct net_device *dev, int indx, u16 *data) 


	status = usb_control_msg(udev, usb_rcvctrlpipe(udev, 0),

				 RTL8187_REQ_GET_REGS, RTL8187_REQT_READ,

				 indx | 0xfe00, 0, usbdata, 2, HZ / 2);

				 indx | 0xfe00, 0, usbdata, 2, 500);

	*data = *usbdata;

	kfree(usbdata);
@@ -467,7 +467,7 @@ int read_nic_dword(struct net_device *dev, int indx, u32 *data) 
	status = usb_control_msg(udev, usb_rcvctrlpipe(udev, 0),

				 RTL8187_REQ_GET_REGS, RTL8187_REQT_READ,

				 (indx & 0xff) | 0xff00, (indx >> 8) & 0x0f,

				 usbdata, 4, HZ / 2);

				 usbdata, 4, 500);

	*data = *usbdata;

	kfree(usbdata);