Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c435285d authored by Joern Engel's avatar Joern Engel Committed by Nicholas Bellinger
Browse files

target: fix unused shift in core_scsi3_pri_report_capabilities 



Clearly a right-shift was meant.  Effectively doesn't make a difference,
as add_len is hard-coded to 8 and the high byte will be zero no matter
which way you shift.  But I hate leaving bad examples for others to
copy.

Found by coverity.

Signed-off-by: default avatarJoern Engel <joern@logfs.org>
Signed-off-by: default avatarNicholas Bellinger <nab@linux-iscsi.org>
parent ce31c1b0

drivers/target/target_core_pr.c

+1 −1
Original line number Diff line number Diff line
@@ -3803,7 +3803,7 @@ core_scsi3_pri_report_capabilities(struct se_cmd *cmd) 
	if (!buf)

		return TCM_LOGICAL_UNIT_COMMUNICATION_FAILURE;



	buf[0] = ((add_len << 8) & 0xff);

	buf[0] = ((add_len >> 8) & 0xff);

	buf[1] = (add_len & 0xff);

	buf[2] |= 0x10; /* CRH: Compatible Reservation Hanlding bit. */

	buf[2] |= 0x08; /* SIP_C: Specify Initiator Ports Capable bit */