Commit c3dcac87 authored Jun 28, 2014 by Himangi Saraogi Committed by Mike Turquette Jul 01, 2014

clk: sunxi: fix devm_ioremap_resource error detection code



devm_ioremap_resource returns an ERR_PTR value, not NULL, on failure.

A simplified version of the semantic match that finds this problem is as
follows:

// <smpl>
@@
expression e,e1;
statement S;
@@

*e = devm_ioremap_resource(...);
if (!e1) S

// </smpl>

Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
Acked-by: Julia Lawall <julia.lawall@lip6.fr>
Acked-by Boris BREZILLON <boris.brezillon@free-electrons.com>
Signed-off-by: Mike Turquette <mturquette@linaro.org>

parent 2a96dfa4

drivers/clk/sunxi/clk-sun6i-apb0-gates.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -29,7 +29,7 @@ static int sun6i_a31_apb0_gates_clk_probe(struct platform_device *pdev)

		r = platform_get_resource(pdev, IORESOURCE_MEM, 0);
		reg = devm_ioremap_resource(&pdev->dev, r);
		if (!reg)
		if (IS_ERR(reg))
		return PTR_ERR(reg);

		clk_parent = of_clk_get_parent_name(np, 0);