Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c34ebbae authored by Francois Romieu's avatar Francois Romieu
Browse files

sis190: remove needless MII reset 



It does not help the auto-negotiation process to settle.

Added a debug message to give some hindsight when things
do not work as expected.

Signed-off-by: default avatarFrancois Romieu <romieu@fr.zoreil.com>
parent 47e47815

drivers/net/sis190.c

+2 −3
Original line number Diff line number Diff line
@@ -899,10 +899,9 @@ static void sis190_phy_task(struct work_struct *work) 
		mod_timer(&tp->timer, jiffies + HZ/10);

	} else if (!(mdio_read_latched(ioaddr, phy_id, MII_BMSR) &

		     BMSR_ANEGCOMPLETE)) {

		net_link(tp, KERN_WARNING "%s: PHY reset until link up.\n",

			 dev->name);

		netif_carrier_off(dev);

		mdio_write(ioaddr, phy_id, MII_BMCR, val | BMCR_RESET);

		net_link(tp, KERN_WARNING "%s: auto-negotiating...\n",

			 dev->name);

		mod_timer(&tp->timer, jiffies + SIS190_PHY_TIMEOUT);

	} else {

		/* Rejoice ! */