Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c28c3583 authored by Miloslav Trmac's avatar Miloslav Trmac Committed by Dmitry Torokhov
Browse files

Input: wistron - do not crash if BIOS does not support interface 



offset can never be < 0 because it has type size_t.  The driver
currently oopses on insmod if BIOS does not support the interface,
instead of refusing to load.

Signed-off-by: default avatarMiloslav Trmac <mitr@volny.cz>
Signed-off-by: default avatarDmitry Torokhov <dtor@mail.ru>
parent ebbac7dd

drivers/input/misc/wistron_btns.c

+3 −3
Original line number Diff line number Diff line
@@ -92,11 +92,11 @@ static void call_bios(struct regs *regs) 
	preempt_enable();

}



static size_t __init locate_wistron_bios(void __iomem *base)

static ssize_t __init locate_wistron_bios(void __iomem *base)

{

	static const unsigned char __initdata signature[] =

		{ 0x42, 0x21, 0x55, 0x30 };

	size_t offset;

	ssize_t offset;



	for (offset = 0; offset < 0x10000; offset += 0x10) {

		if (check_signature(base + offset, signature,
@@ -109,7 +109,7 @@ static size_t __init locate_wistron_bios(void __iomem *base) 
static int __init map_bios(void)

{

	void __iomem *base;

	size_t offset;

	ssize_t offset;

	u32 entry_point;



	base = ioremap(0xF0000, 0x10000); /* Can't fail */