Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c0510383 authored by Alexander Usyskin's avatar Alexander Usyskin Committed by Greg Kroah-Hartman
Browse files

mei: txe: don't clean an unprocessed interrupt cause. 



commit 43605e293eb13c07acb546c14f407a271837af17 upstream.

SEC registers are not accessible when the TXE device is in low power
state, hence the SEC interrupt cannot be processed if device is not
awake.

In some rare cases entrance to low power state (aliveness off) and input
ready bits can be signaled at the same time, resulting in communication
stall as input ready won't be signaled again after waking up. To resolve
this IPC_HHIER_SEC bit in HHISR_REG should not be cleaned if the
interrupt is not processed.

Signed-off-by: default avatarAlexander Usyskin <alexander.usyskin@intel.com>
Signed-off-by: default avatarTomas Winkler <tomas.winkler@intel.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent dc70a200

drivers/misc/mei/hw-txe.c

+4 −2
Original line number Diff line number Diff line
@@ -972,11 +972,13 @@ static bool mei_txe_check_and_ack_intrs(struct mei_device *dev, bool do_ack) 
	hisr = mei_txe_br_reg_read(hw, HISR_REG);



	aliveness = mei_txe_aliveness_get(dev);

	if (hhisr & IPC_HHIER_SEC && aliveness)

	if (hhisr & IPC_HHIER_SEC && aliveness) {

		ipc_isr = mei_txe_sec_reg_read_silent(hw,

				SEC_IPC_HOST_INT_STATUS_REG);

	else

	} else {

		ipc_isr = 0;

		hhisr &= ~IPC_HHIER_SEC;

	}



	generated = generated ||

		(hisr & HISR_INT_STS_MSK) ||