Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit be3d91ce authored by Sai Krishna Potthuri's avatar Sai Krishna Potthuri Committed by Greg Kroah-Hartman
Browse files

EDAC/synopsys: Fix wrong value type assignment for edac_mode 



commit 5297cfa6bdf93e3889f78f9b482e2a595a376083 upstream.

dimm->edac_mode contains values of type enum edac_type - not the
corresponding capability flags. Fix that.

Issue caught by Coverity check "enumerated type mixed with another
type."

 [ bp: Rewrite commit message, add tags. ]

Fixes: ae9b56e3 ("EDAC, synps: Add EDAC support for zynq ddr ecc controller")
Signed-off-by: default avatarSai Krishna Potthuri <lakshmi.sai.krishna.potthuri@xilinx.com>
Signed-off-by: default avatarShubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
Signed-off-by: default avatarBorislav Petkov <bp@suse.de>
Cc: <stable@vger.kernel.org>
Link: https://lkml.kernel.org/r/20210818072315.15149-1-shubhrajyoti.datta@xilinx.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 112b8f03

drivers/edac/synopsys_edac.c

+1 −1
Original line number Diff line number Diff line
@@ -371,7 +371,7 @@ static int synps_edac_init_csrows(struct mem_ctl_info *mci) 


		for (j = 0; j < csi->nr_channels; j++) {

			dimm            = csi->channels[j]->dimm;

			dimm->edac_mode = EDAC_FLAG_SECDED;

			dimm->edac_mode = EDAC_SECDED;

			dimm->mtype     = synps_edac_get_mtype(priv->baseaddr);

			dimm->nr_pages  = (size >> PAGE_SHIFT) / csi->nr_channels;

			dimm->grain     = SYNPS_EDAC_ERR_GRAIN;