Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

This project is archived. Its data is read-only.

Commit bd2033f2 authored Oct 10, 2006 by Takashi Iwai Committed by Jaroslav Kysela Dec 20, 2006

[ALSA] hda-codec - Fix wrong error checks in patch_{realtek,analog}.c



Fix wrong error checks of *_ch_mode_put() in patch_realtek.c and
patch_analog.c.  snd_hda_ch_mode_put() could return a positive
value for success, too.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Jaroslav Kysela <perex@suse.cz>

parent d9301263

sound/pci/hda/patch_analog.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1640,7 +1640,7 @@ static int ad198x_ch_mode_put(struct snd_kcontrol *kcontrol,
		int err = snd_hda_ch_mode_put(codec, ucontrol, spec->channel_mode,
		spec->num_channel_mode,
		&spec->multiout.max_channels);
		if (! err && spec->need_dac_fix)
		if (err >= 0 && spec->need_dac_fix)
		spec->multiout.num_dacs = spec->multiout.max_channels / 2;
		return err;
		}

sound/pci/hda/patch_realtek.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -271,7 +271,7 @@ static int alc_ch_mode_put(struct snd_kcontrol *kcontrol,
		int err = snd_hda_ch_mode_put(codec, ucontrol, spec->channel_mode,
		spec->num_channel_mode,
		&spec->multiout.max_channels);
		if (! err && spec->need_dac_fix)
		if (err >= 0 && spec->need_dac_fix)
		spec->multiout.num_dacs = spec->multiout.max_channels / 2;
		return err;
		}