Commit bba42776 authored Dec 02, 2011 by Andreas Ruprecht Committed by Greg Kroah-Hartman Dec 08, 2011

Staging: iio/accel: Changed data type of mask in store_measurement_mode() to u8



In sca3000_store_measurement_mode() we parse a value from a string
buffer via kstrtou8, and store the parsed value into a u8 after
and-ing it with mask.

As we are only interested in the lowest two bits here and mask is
initialized with a fixed value 0x03, mask may as well be a u8.

Signed-off-by: Andreas Ruprecht <rupran@einserver.de>
Acked-by: Jonathan Cameron <jic23@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

parent 0c9d1964

drivers/staging/iio/accel/sca3000_core.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -382,7 +382,7 @@ sca3000_store_measurement_mode(struct device *dev,
	struct iio_dev *indio_dev = dev_get_drvdata(dev);		struct iio_dev *indio_dev = dev_get_drvdata(dev);
	struct sca3000_state *st = iio_priv(indio_dev);		struct sca3000_state *st = iio_priv(indio_dev);
	int ret;		int ret;
	int mask = 0x03;		u8 mask = 0x03;
	u8 val;		u8 val;

	mutex_lock(&st->lock);		mutex_lock(&st->lock);