Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ba5ea951 authored by Stanislaw Gruszka's avatar Stanislaw Gruszka Committed by Thomas Gleixner
Browse files

posix-cpu-timers: optimize and document timer_create callback 



We have already new_timer initialized to all-zeros hence in function
initializations are not needed. Document function expectation about
new_timer argument as well.

Signed-off-by: default avatarStanislaw Gruszka <sgruszka@redhat.com>
Cc: johnstul@us.ibm.com
Cc: Oleg Nesterov <oleg@redhat.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
parent 8e1a928a

kernel/posix-cpu-timers.c

+2 −3
Original line number Diff line number Diff line
@@ -384,7 +384,8 @@ int posix_cpu_clock_get(const clockid_t which_clock, struct timespec *tp) 


/*

 * Validate the clockid_t for a new CPU-clock timer, and initialize the timer.

 * This is called from sys_timer_create with the new timer already locked.

 * This is called from sys_timer_create() and do_cpu_nanosleep() with the

 * new timer already all-zeros initialized.

 */

int posix_cpu_timer_create(struct k_itimer *new_timer)

{
@@ -396,8 +397,6 @@ int posix_cpu_timer_create(struct k_itimer *new_timer) 
		return -EINVAL;



	INIT_LIST_HEAD(&new_timer->it.cpu.entry);

	new_timer->it.cpu.incr.sched = 0;

	new_timer->it.cpu.expires.sched = 0;



	read_lock(&tasklist_lock);

	if (CPUCLOCK_PERTHREAD(new_timer->it_clock)) {