Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ba57435e authored by Ani Sinha's avatar Ani Sinha Committed by Gerrit - the friendly Code Review server
Browse files

sysrq: Fix warning in sysrq generated crash.



Commit 984d74a7 ("sysrq: rcu-ify __handle_sysrq") replaced
spin_lock_irqsave() calls with rcu_read_lock() calls in sysrq. Since
rcu_read_lock() does not disable preemption, faulthandler_disabled() in
__do_page_fault() in x86/fault.c returns false. When the code later calls
might_sleep() in the pagefault handler, we get the following warning:

BUG: sleeping function called from invalid context at ../arch/x86/mm/fault.c:1187
in_atomic(): 0, irqs_disabled(): 0, pid: 4706, name: bash
Preemption disabled at:[<ffffffff81484339>] printk+0x48/0x4a

To fix this, we release the RCU read lock before we crash.

Tested this patch on linux 3.18 by booting off one of our boards.

Fixes: 984d74a7 ("sysrq: rcu-ify __handle_sysrq")

Change-Id: I1827413e7e4fede197b3ebb6216239c07ae33a71
Signed-off-by: default avatarAni Sinha <ani@arista.com>
Reviewed-by: default avatarRik van Riel <riel@redhat.com>
Signed-off-by: default avatarPaul E. McKenney <paulmck@linux.vnet.ibm.com>
Git-commit: 984cf355aeaa8f2eda3861b50d0e8d3e3f77e83b
Git-repo: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git


Signed-off-by: default avatarGaurav Kohli <gkohli@codeaurora.org>
parent fa7978ca
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment