Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b72c2009 authored by Jaccon Bastiaansen's avatar Jaccon Bastiaansen Committed by David S. Miller
Browse files

cs89x0 : packet reception not working 



The RxCFG register of the CS89x0 could be configured incorrectly
(because of misplaced parentheses), resulting in the disabling
of packet reception.

Signed-off-by: default avatarJaccon Bastiaansen <jaccon.bastiaansen@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 0dcd5052

drivers/net/ethernet/cirrus/cs89x0.c

+5 −5
Original line number Diff line number Diff line
@@ -1243,6 +1243,7 @@ static void set_multicast_list(struct net_device *dev) 
{

	struct net_local *lp = netdev_priv(dev);

	unsigned long flags;

	u16 cfg;



	spin_lock_irqsave(&lp->lock, flags);

	if (dev->flags & IFF_PROMISC)
@@ -1260,11 +1261,10 @@ static void set_multicast_list(struct net_device *dev) 
	/* in promiscuous mode, we accept errored packets,

	 * so we have to enable interrupts on them also

	 */

	writereg(dev, PP_RxCFG,

		 (lp->curr_rx_cfg |

		  (lp->rx_mode == RX_ALL_ACCEPT)

		  ? (RX_CRC_ERROR_ENBL | RX_RUNT_ENBL | RX_EXTRA_DATA_ENBL)

		  : 0));

	cfg = lp->curr_rx_cfg;

	if (lp->rx_mode == RX_ALL_ACCEPT)

		cfg |= RX_CRC_ERROR_ENBL | RX_RUNT_ENBL | RX_EXTRA_DATA_ENBL;

	writereg(dev, PP_RxCFG, cfg);

	spin_unlock_irqrestore(&lp->lock, flags);

}