Commit ada83daa authored Aug 21, 2007 by Andre Detsch Committed by Paul Mackerras Aug 30, 2007

[POWERPC] spufs: Don't call spu_run_init from spu_reacquire_runnable



This fixes a major bug which was happening when a SPU thread advances
its execution right after being restored to a SPU.  A potentially
outdated NPC value was being (re)written to the SPU.

So, spu_run_init, in this case, was either not doing anything relevant,
or breaking the execution of the SPU thread.

This fixes a common problem of losing a mailbox write when it was done
to a saved context.

Signed-off-by: Andre Detsch <adetsch@br.ibm.com>
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Signed-off-by: Paul Mackerras <paulus@samba.org>

parent 62ee68e3

arch/powerpc/platforms/cell/spufs/run.c

+1 −5

Original line number	Diff line number	Diff line
		@@ -193,11 +193,7 @@ static int spu_reacquire_runnable(struct spu_context ctx, u32 npc,
		if (ret)
		return ret;

		ret = spu_run_init(ctx, npc);
		if (ret) {
		spu_release(ctx);
		return ret;
		}
		spuctx_switch_state(ctx, SPU_UTIL_USER);
		return 0;
		}