Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ac9be8ee authored by David Ahern's avatar David Ahern Committed by Arnaldo Carvalho de Melo
Browse files

perf trace: Make command line arguments consistent with perf-record 



Common arguments like thread id, CPU list, mmap pages, etc should be
consistent across perf commands.

v3: Updated man page
v2: rebased to latest core branch

Signed-off-by: default avatarDavid Ahern <dsahern@gmail.com>
Link: http://lkml.kernel.org/r/1377018945-21940-1-git-send-email-dsahern@gmail.com


Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent c24ff998

tools/perf/Documentation/perf-trace.txt

+6 −0
Original line number Original line Diff line number Diff line
@@ -23,6 +23,7 @@ analysis phases. 
OPTIONS

OPTIONS

-------

-------





-a::

--all-cpus::

--all-cpus::

        System-wide collection from all CPUs.

        System-wide collection from all CPUs.
@@ -38,18 +39,23 @@ OPTIONS 
--pid=::

--pid=::

	Record events on existing process ID (comma separated list).

	Record events on existing process ID (comma separated list).





-t::

--tid=::

--tid=::

        Record events on existing thread ID (comma separated list).

        Record events on existing thread ID (comma separated list).





-u::

--uid=::

--uid=::

        Record events in threads owned by uid. Name or number.

        Record events in threads owned by uid. Name or number.





-i::

--no-inherit::

--no-inherit::

	Child tasks do not inherit counters.

	Child tasks do not inherit counters.





-m::

--mmap-pages=::

--mmap-pages=::

	Number of mmap data pages. Must be a power of two.

	Number of mmap data pages. Must be a power of two.





-C::

--cpu::

--cpu::

Collect samples only on the list of CPUs provided. Multiple CPUs can be provided as a

Collect samples only on the list of CPUs provided. Multiple CPUs can be provided as a

comma-separated list with no space: 0,1. Ranges of CPUs are specified with -: 0-2.

comma-separated list with no space: 0,1. Ranges of CPUs are specified with -: 0-2.

tools/perf/builtin-trace.c

+6 −6
Original line number Original line Diff line number Diff line
@@ -693,17 +693,17 @@ int cmd_trace(int argc, const char **argv, const char *prefix __maybe_unused) 
	OPT_STRING('o', "output", &output_name, "file", "output file name"),

	OPT_STRING('o', "output", &output_name, "file", "output file name"),

	OPT_STRING('p', "pid", &trace.opts.target.pid, "pid",

	OPT_STRING('p', "pid", &trace.opts.target.pid, "pid",

		    "trace events on existing process id"),

		    "trace events on existing process id"),

	OPT_STRING(0, "tid", &trace.opts.target.tid, "tid",

	OPT_STRING('t', "tid", &trace.opts.target.tid, "tid",

		    "trace events on existing thread id"),

		    "trace events on existing thread id"),

	OPT_BOOLEAN(0, "all-cpus", &trace.opts.target.system_wide,

	OPT_BOOLEAN('a', "all-cpus", &trace.opts.target.system_wide,

		    "system-wide collection from all CPUs"),

		    "system-wide collection from all CPUs"),

	OPT_STRING(0, "cpu", &trace.opts.target.cpu_list, "cpu",

	OPT_STRING('C', "cpu", &trace.opts.target.cpu_list, "cpu",

		    "list of cpus to monitor"),

		    "list of cpus to monitor"),

	OPT_BOOLEAN(0, "no-inherit", &trace.opts.no_inherit,

	OPT_BOOLEAN('i', "no-inherit", &trace.opts.no_inherit,

		    "child tasks do not inherit counters"),

		    "child tasks do not inherit counters"),

	OPT_UINTEGER(0, "mmap-pages", &trace.opts.mmap_pages,

	OPT_UINTEGER('m', "mmap-pages", &trace.opts.mmap_pages,

		     "number of mmap data pages"),

		     "number of mmap data pages"),

	OPT_STRING(0, "uid", &trace.opts.target.uid_str, "user",

	OPT_STRING('u', "uid", &trace.opts.target.uid_str, "user",

		   "user to profile"),

		   "user to profile"),

	OPT_CALLBACK(0, "duration", &trace, "float",

	OPT_CALLBACK(0, "duration", &trace, "float",

		     "show only events with duration > N.M ms",

		     "show only events with duration > N.M ms",