Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ac1ae5f3 authored by Eric Dumazet's avatar Eric Dumazet Committed by David S. Miller
Browse files

be2net: dont pull too much data in skb linear part 



skb_fill_rx_data() pulls 64 byte of data in skb->data

Its too much for TCP (with no options) on IPv4, as total size of headers
is 14 + 40 = 54

This means tcp stack and splice() are suboptimal, since tcp payload
is in part in tcp->data, and in part in skb frag.

Signed-off-by: default avatarEric Dumazet <edumazet@google.com>
Acked-by: default avatarPadmanabh Ratnakar <padmanabh.ratnakar@emulex.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent d2ee62e9

drivers/net/ethernet/emulex/benet/be_main.c

+3 −3
Original line number Diff line number Diff line
@@ -1228,16 +1228,16 @@ static void skb_fill_rx_data(struct be_rx_obj *rxo, struct sk_buff *skb, 
	/* Copy data in the first descriptor of this completion */

	curr_frag_len = min(rxcp->pkt_size, rx_frag_size);



	/* Copy the header portion into skb_data */

	hdr_len = min(BE_HDR_LEN, curr_frag_len);

	memcpy(skb->data, start, hdr_len);

	skb->len = curr_frag_len;

	if (curr_frag_len <= BE_HDR_LEN) { /* tiny packet */

		memcpy(skb->data, start, curr_frag_len);

		/* Complete packet has now been moved to data */

		put_page(page_info->page);

		skb->data_len = 0;

		skb->tail += curr_frag_len;

	} else {

		hdr_len = ETH_HLEN;

		memcpy(skb->data, start, hdr_len);

		skb_shinfo(skb)->nr_frags = 1;

		skb_frag_set_page(skb, 0, page_info->page);

		skb_shinfo(skb)->frags[0].page_offset =