Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a73c2a2f authored by Sagi Grimberg's avatar Sagi Grimberg Committed by Nicholas Bellinger
Browse files

libiscsi: Use scsi helper to set information descriptor 



In case encountered a PI error, use scsi_set_sense_information
instead of open coding information descriptor format.

Signed-off-by: default avatarSagi Grimberg <sagig@mellanox.com>
Reviewed-by: default avatarHannes Reinecke <hare@suse.de>
Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
Reviewed-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: default avatarNicholas Bellinger <nab@linux-iscsi.org>
parent 4e4937e8

drivers/scsi/libiscsi.c

+3 −6
Original line number Diff line number Diff line
@@ -853,12 +853,9 @@ static void iscsi_scsi_cmd_rsp(struct iscsi_conn *conn, struct iscsi_hdr *hdr, 
				     SAM_STAT_CHECK_CONDITION;

			scsi_build_sense_buffer(1, sc->sense_buffer,

						ILLEGAL_REQUEST, 0x10, ascq);

			sc->sense_buffer[7] = 0xc; /* Additional sense length */

			sc->sense_buffer[8] = 0;   /* Information desc type */

			sc->sense_buffer[9] = 0xa; /* Additional desc length */

			sc->sense_buffer[10] = 0x80; /* Validity bit */



			put_unaligned_be64(sector, &sc->sense_buffer[12]);

			scsi_set_sense_information(sc->sense_buffer,

						   SCSI_SENSE_BUFFERSIZE,

						   sector);

			goto out;

		}

	}