Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a5f958c4 authored by Richard Weinberger's avatar Richard Weinberger Committed by Greg Kroah-Hartman
Browse files

ubi: Fix Fastmap's update_vol() 



commit f7d11b33d4e8cedf19367c09b891bbc705163976 upstream.

Usually Fastmap is free to consider every PEB in one of the pools
as newer than the existing PEB. Since PEBs in a pool are by definition
newer than everything else.
But update_vol() missed the case that a pool can contain more than
one candidate.

Cc: <stable@vger.kernel.org>
Fixes: dbb7d2a8 ("UBI: Add fastmap core")
Signed-off-by: default avatarRichard Weinberger <richard@nod.at>
Reviewed-by: default avatarBoris Brezillon <boris.brezillon@free-electrons.com>
Signed-off-by: default avatarRichard Weinberger <richard@nod.at>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 000b4c28

drivers/mtd/ubi/fastmap.c

+1 −0
Original line number Diff line number Diff line
@@ -326,6 +326,7 @@ static int update_vol(struct ubi_device *ubi, struct ubi_attach_info *ai, 
			aeb->pnum = new_aeb->pnum;

			aeb->copy_flag = new_vh->copy_flag;

			aeb->scrub = new_aeb->scrub;

			aeb->sqnum = new_aeb->sqnum;

			kmem_cache_free(ai->aeb_slab_cache, new_aeb);



		/* new_aeb is older */