Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a1ddefd8 authored by Jani Nikula's avatar Jani Nikula Committed by Daniel Vetter
Browse files

drm/i915/dp: return number of bytes written for short aux/i2c writes 



Allow for a larger receive data size, and check if the receiver returned
the number of bytes written. Without this, we've basically skipped all
the unwritten bytes for short writes.

Signed-off-by: default avatarJani Nikula <jani.nikula@intel.com>
Reviewed-by: default avatarVille Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
parent 94ca719e

drivers/gpu/drm/i915/intel_dp.c

+8 −3
Original line number Diff line number Diff line
@@ -951,7 +951,7 @@ intel_dp_aux_transfer(struct drm_dp_aux *aux, struct drm_dp_aux_msg *msg) 
	case DP_AUX_NATIVE_WRITE:

	case DP_AUX_I2C_WRITE:

		txsize = msg->size ? HEADER_SIZE + msg->size : BARE_ADDRESS_SIZE;

		rxsize = 1;

		rxsize = 2; /* 0 or 1 data bytes */



		if (WARN_ON(txsize > 20))

			return -E2BIG;
@@ -962,9 +962,14 @@ intel_dp_aux_transfer(struct drm_dp_aux *aux, struct drm_dp_aux_msg *msg) 
		if (ret > 0) {

			msg->reply = rxbuf[0] >> 4;



			if (ret > 1) {

				/* Number of bytes written in a short write. */

				ret = clamp_t(int, rxbuf[1], 0, msg->size);

			} else {

				/* Return payload size. */

				ret = msg->size;

			}

		}

		break;



	case DP_AUX_NATIVE_READ: