Commit a06998b8 authored Jun 07, 2012 by Eric Dumazet Committed by David S. Miller Jun 07, 2012

net: l2tp_eth: fix kernel panic on rmmod l2tp_eth



We must prevent module unloading if some devices are still attached to
l2tp_eth driver.

Signed-off-by: Eric Dumazet <edumazet@google.com>
Reported-by: Denys Fedoryshchenko <denys@visp.net.lb>
Tested-by: Denys Fedoryshchenko <denys@visp.net.lb>
Cc: James Chapman <jchapman@katalix.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent da2e8526

net/l2tp/l2tp_eth.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -162,6 +162,7 @@ static void l2tp_eth_delete(struct l2tp_session *session)
		if (dev) {
		unregister_netdev(dev);
		spriv->dev = NULL;
		module_put(THIS_MODULE);
		}
		}
		}
		@@ -249,6 +250,7 @@ static int l2tp_eth_create(struct net *net, u32 tunnel_id, u32 session_id, u32 p
		if (rc < 0)
		goto out_del_dev;

		__module_get(THIS_MODULE);
		/* Must be done after register_netdev() */
		strlcpy(session->ifname, dev->name, IFNAMSIZ);