Commit a0183e20 authored Jun 02, 2021 by Jiapeng Chong Committed by Sasha Levin Jun 30, 2021

rtnetlink: Fix missing error code in rtnl_bridge_notify()



[ Upstream commit a8db57c1d285c758adc7fb43d6e2bad2554106e1 ]

The error code is missing in this code scenario, add the error code
'-EINVAL' to the return value 'err'.

Eliminate the follow smatch warning:

net/core/rtnetlink.c:4834 rtnl_bridge_notify() warn: missing error code
'err'.

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 61ec5a0e

net/core/rtnetlink.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -3240,8 +3240,10 @@ static int rtnl_bridge_notify(struct net_device *dev)
		if (err < 0)
		goto errout;

		if (!skb->len)
		if (!skb->len) {
		err = -EINVAL;
		goto errout;
		}

		rtnl_notify(skb, net, 0, RTNLGRP_LINK, NULL, GFP_ATOMIC);
		return 0;