Commit 9f6d20ff authored Jun 06, 2013 by Alexey Khoroshilov Committed by Greg Kroah-Hartman Jun 06, 2013

tty/serial/sirf: fix error propagation in sirfsoc_uart_probe()



If pinctrl_get_select_default() fails, sirfsoc_uart_probe()
returns IS_ERR(result) instead of PTR_ERR(result).

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 7f25301d

drivers/tty/serial/sirfsoc_uart.c

+3 −2

Original line number	Diff line number	Diff line
		@@ -687,10 +687,11 @@ int sirfsoc_uart_probe(struct platform_device *pdev)

		if (sirfport->hw_flow_ctrl) {
		sirfport->p = pinctrl_get_select_default(&pdev->dev);
		ret = IS_ERR(sirfport->p);
		if (ret)
		if (IS_ERR(sirfport->p)) {
		ret = PTR_ERR(sirfport->p);
		goto err;
		}
		}

		sirfport->clk = clk_get(&pdev->dev, NULL);
		if (IS_ERR(sirfport->clk)) {