Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

This project is archived. Its data is read-only.

Commit 9edfae3f authored Apr 21, 2014 by Sam Ravnborg Committed by David S. Miller Apr 29, 2014

sparc32: fix sparse warnings in unaligned_32.c

Fix following warnings:
unaligned_32.c:146:15: warning: symbol 'safe_compute_effective_address' was not declared. Should it be static?
unaligned_32.c:235:17: warning: symbol 'kernel_unaligned_trap' was not declared. Should it be static?
unaligned_32.c:319:17: warning: symbol 'user_unaligned_trap' was not declared. Should it be static?

Add proper declarations in kernel.h + setup.h

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent c8c8782d

arch/sparc/include/asm/setup.h

+3 −0

Original line number	Original line	Diff line number	Diff line
	@@ -42,6 +42,9 @@ extern unsigned long cmdline_memory_size;
	/* devices.c */		/* devices.c */
	void __init device_scan(void);		void __init device_scan(void);

			/* unaligned_32.c */
			unsigned long safe_compute_effective_address(struct pt_regs *, unsigned int);

	#endif		#endif

	extern void sun_do_break(void);		extern void sun_do_break(void);

arch/sparc/kernel/kernel.h

+4 −0

Original line number	Original line	Diff line number	Diff line
	@@ -113,6 +113,10 @@ asmlinkage int do_sys_sigstack(struct sigstack __user *ssptr,
	/* ptrace_32.c */		/* ptrace_32.c */
	asmlinkage int syscall_trace(struct pt_regs *regs, int syscall_exit_p);		asmlinkage int syscall_trace(struct pt_regs *regs, int syscall_exit_p);

			/* unaligned_32.c */
			asmlinkage void kernel_unaligned_trap(struct pt_regs *regs, unsigned int insn);
			asmlinkage void user_unaligned_trap(struct pt_regs *regs, unsigned int insn);

	/* windows.c */		/* windows.c */
	void try_to_clear_window_buffer(struct pt_regs *regs, int who);		void try_to_clear_window_buffer(struct pt_regs *regs, int who);

arch/sparc/kernel/unaligned_32.c

+4 −0

Original line number	Original line	Diff line number	Diff line
	@@ -16,6 +16,10 @@
	#include <linux/smp.h>		#include <linux/smp.h>
	#include <linux/perf_event.h>		#include <linux/perf_event.h>

			#include <asm/setup.h>

			#include "kernel.h"

	enum direction {		enum direction {
	load, /* ld, ldd, ldh, ldsh */		load, /* ld, ldd, ldh, ldsh */
	store, /* st, std, sth, stsh */		store, /* st, std, sth, stsh */

arch/sparc/mm/fault_32.c

+1 −3

Original line number	Original line	Diff line number	Diff line
	@@ -26,6 +26,7 @@
	#include <asm/pgtable.h>		#include <asm/pgtable.h>
	#include <asm/openprom.h>		#include <asm/openprom.h>
	#include <asm/oplib.h>		#include <asm/oplib.h>
			#include <asm/setup.h>
	#include <asm/smp.h>		#include <asm/smp.h>
	#include <asm/traps.h>		#include <asm/traps.h>
	#include <asm/uaccess.h>		#include <asm/uaccess.h>
	@@ -140,9 +141,6 @@ static void __do_fault_siginfo(int code, int sig, struct pt_regs *regs,
	force_sig_info (sig, &info, current);		force_sig_info (sig, &info, current);
	}		}

	extern unsigned long safe_compute_effective_address(struct pt_regs *,
	unsigned int);

	static unsigned long compute_si_addr(struct pt_regs *regs, int text_fault)		static unsigned long compute_si_addr(struct pt_regs *regs, int text_fault)
	{		{
	unsigned int insn;		unsigned int insn;