Commit 9c405157 authored Feb 27, 2016 by Colin Ian King Committed by Greg Kroah-Hartman Nov 15, 2017

PKCS#7: fix unitialized boolean 'want'



commit 06aae592425701851e02bb850cb9f4997f0ae163 upstream.

The boolean want is not initialized and hence garbage. The default should
be false (later it is only set to true on tne sinfo->authattrs check).

Found with static analysis using CoverityScan

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: David Howells <dhowells@redhat.com>
Cc: Ben Hutchings <ben.hutchings@codethink.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent b01f1d60

crypto/asymmetric_keys/pkcs7_parser.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -87,7 +87,7 @@ EXPORT_SYMBOL_GPL(pkcs7_free_message);
		static int pkcs7_check_authattrs(struct pkcs7_message *msg)
		{
		struct pkcs7_signed_info *sinfo;
		bool want;
		bool want = false;

		sinfo = msg->signed_infos;
		if (!sinfo)