Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9a1875e6 authored by David S. Miller's avatar David S. Miller
Browse files

[NET]: Fully fix the memory leaks in sys_accept().



Andi Kleen was right, fput() on sock->file will end up calling
sock_release() if necessary.  So here is the rest of his version
of the fix for these leaks.

Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 2722971c
Loading
Loading
Loading
Loading
+2 −3
Original line number Diff line number Diff line
@@ -1418,7 +1418,8 @@ asmlinkage long sys_accept(int fd, struct sockaddr __user *upeer_sockaddr, int _
	newfd = sock_alloc_fd(&newfile);
	if (unlikely(newfd < 0)) {
		err = newfd;
		goto out_release;
		sock_release(newsock);
		goto out_put;
	}

	err = sock_attach_fd(newsock, newfile);
@@ -1457,8 +1458,6 @@ out:
out_fd:
	fput(newfile);
	put_unused_fd(newfd);
out_release:
	sock_release(newsock);
	goto out_put;
}