Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9993e0fe authored by Stefan Richter's avatar Stefan Richter
Browse files

firewire: ohci: fix regression with Agere FW643 rev 06, disable MSI 



Agere FW643 rev 06, listed as "11c1:5901 (rev 06) (prog-if 10 [OHCI])",
produced SBP-2 I/O errors since kernel 2.6.36.  Disabling MSI fixes it.

Since MSI work on Agere FW643-E (same vendor and device ID, but rev 07),
introduce a device revision field into firewire-ohci's quirks list so
that different quirks can be defined for older and newer revisions.

Reported-by: default avatarJonathan Isom <jeisom@gmail.com>
Signed-off-by: default avatarStefan Richter <stefanr@s5r6.in-berlin.de>
Cc: <stable@kernel.org> # 2.6.36.y
parent af0cdf49

drivers/firewire/ohci.c

+33 −15
Original line number Diff line number Diff line
@@ -242,6 +242,7 @@ static inline struct fw_ohci *fw_ohci(struct fw_card *card) 


static char ohci_driver_name[] = KBUILD_MODNAME;



#define PCI_DEVICE_ID_AGERE_FW643	0x5901

#define PCI_DEVICE_ID_JMICRON_JMB38X_FW	0x2380

#define PCI_DEVICE_ID_TI_TSB12LV22	0x8009
@@ -253,19 +254,34 @@ static char ohci_driver_name[] = KBUILD_MODNAME; 


/* In case of multiple matches in ohci_quirks[], only the first one is used. */

static const struct {

	unsigned short vendor, device, flags;

	unsigned short vendor, device, revision, flags;

} ohci_quirks[] = {

	{PCI_VENDOR_ID_TI,	PCI_DEVICE_ID_TI_TSB12LV22, QUIRK_CYCLE_TIMER |

							    QUIRK_RESET_PACKET |

							    QUIRK_NO_1394A},

	{PCI_VENDOR_ID_TI,	PCI_ANY_ID,	QUIRK_RESET_PACKET},

	{PCI_VENDOR_ID_AL,	PCI_ANY_ID,	QUIRK_CYCLE_TIMER},

	{PCI_VENDOR_ID_JMICRON,	PCI_DEVICE_ID_JMICRON_JMB38X_FW, QUIRK_NO_MSI},

	{PCI_VENDOR_ID_NEC,	PCI_ANY_ID,	QUIRK_CYCLE_TIMER},

	{PCI_VENDOR_ID_VIA,	PCI_ANY_ID,	QUIRK_CYCLE_TIMER |

	{PCI_VENDOR_ID_AL, PCI_ANY_ID, PCI_ANY_ID,

		QUIRK_CYCLE_TIMER},



	{PCI_VENDOR_ID_APPLE, PCI_DEVICE_ID_APPLE_UNI_N_FW, PCI_ANY_ID,

		QUIRK_BE_HEADERS},



	{PCI_VENDOR_ID_ATT, PCI_DEVICE_ID_AGERE_FW643, 6,

		QUIRK_NO_MSI},

	{PCI_VENDOR_ID_RICOH,	PCI_ANY_ID,	QUIRK_CYCLE_TIMER},

	{PCI_VENDOR_ID_APPLE,	PCI_DEVICE_ID_APPLE_UNI_N_FW, QUIRK_BE_HEADERS},



	{PCI_VENDOR_ID_JMICRON, PCI_DEVICE_ID_JMICRON_JMB38X_FW, PCI_ANY_ID,

		QUIRK_NO_MSI},



	{PCI_VENDOR_ID_NEC, PCI_ANY_ID, PCI_ANY_ID,

		QUIRK_CYCLE_TIMER},



	{PCI_VENDOR_ID_RICOH, PCI_ANY_ID, PCI_ANY_ID,

		QUIRK_CYCLE_TIMER},



	{PCI_VENDOR_ID_TI, PCI_DEVICE_ID_TI_TSB12LV22, PCI_ANY_ID,

		QUIRK_CYCLE_TIMER | QUIRK_RESET_PACKET | QUIRK_NO_1394A},



	{PCI_VENDOR_ID_TI, PCI_ANY_ID, PCI_ANY_ID,

		QUIRK_RESET_PACKET},



	{PCI_VENDOR_ID_VIA, PCI_ANY_ID, PCI_ANY_ID,

		QUIRK_CYCLE_TIMER | QUIRK_NO_MSI},

};



/* This overrides anything that was found in ohci_quirks[]. */
@@ -2928,9 +2944,11 @@ static int __devinit pci_probe(struct pci_dev *dev, 
	}



	for (i = 0; i < ARRAY_SIZE(ohci_quirks); i++)

		if (ohci_quirks[i].vendor == dev->vendor &&

		    (ohci_quirks[i].device == dev->device ||

		     ohci_quirks[i].device == (unsigned short)PCI_ANY_ID)) {

		if ((ohci_quirks[i].vendor == dev->vendor) &&

		    (ohci_quirks[i].device == (unsigned short)PCI_ANY_ID ||

		     ohci_quirks[i].device == dev->device) &&

		    (ohci_quirks[i].revision == (unsigned short)PCI_ANY_ID ||

		     ohci_quirks[i].revision >= dev->revision)) {

			ohci->quirks = ohci_quirks[i].flags;

			break;

		}