Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9895c503 authored by Julia Lawall's avatar Julia Lawall Committed by David S. Miller
Browse files

ksz884x: delete useless variable 

Delete a variable that is at most only assigned to a constant, but never
used otherwise.  In this code, it is the variable result that is used for
the return code, not rc.

A simplified version of the semantic patch that fixes this problem is as
follows: (http://coccinelle.lip6.fr/

)

// <smpl>
@@
type T;
identifier i;
constant c;
@@

-T i;
<... when != i
-i = c;
...>
// </smpl>

Signed-off-by: default avatarJulia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent e3e4e01c

drivers/net/ethernet/micrel/ksz884x.c

+0 −3
Original line number Original line Diff line number Diff line
@@ -5853,15 +5853,12 @@ static int netdev_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd) 
	struct dev_info *hw_priv = priv->adapter;

	struct dev_info *hw_priv = priv->adapter;

	struct ksz_hw *hw = &hw_priv->hw;

	struct ksz_hw *hw = &hw_priv->hw;

	struct ksz_port *port = &priv->port;

	struct ksz_port *port = &priv->port;

	int rc;

	int result = 0;

	int result = 0;

	struct mii_ioctl_data *data = if_mii(ifr);

	struct mii_ioctl_data *data = if_mii(ifr);





	if (down_interruptible(&priv->proc_sem))

	if (down_interruptible(&priv->proc_sem))

		return -ERESTARTSYS;

		return -ERESTARTSYS;





	/* assume success */

	rc = 0;

	switch (cmd) {

	switch (cmd) {

	/* Get address of MII PHY in use. */

	/* Get address of MII PHY in use. */

	case SIOCGMIIPHY:

	case SIOCGMIIPHY: