Commit 97a2eba1 authored Oct 01, 2016 by Miklos Szeredi Committed by Greg Kroah-Hartman Oct 22, 2016

fuse: invalidate dir dentry after chmod



commit 5e2b8828ff3d79aca8c3a1730652758753205b61 upstream.

Without "default_permissions" the userspace filesystem's lookup operation
needs to perform the check for search permission on the directory.

If directory does not allow search for everyone (this is quite rare) then
userspace filesystem has to set entry timeout to zero to make sure
permissions are always performed.

Changing the mode bits of the directory should also invalidate the
(previously cached) dentry to make sure the next lookup will have a chance
of updating the timeout, if needed.

Reported-by: Jean-Pierre André <jean-pierre.andre@wanadoo.fr>
Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 80b742b8

fs/fuse/dir.c

+10 −2

Original line number	Diff line number	Diff line
		@@ -1697,14 +1697,22 @@ error:
		static int fuse_setattr(struct dentry entry, struct iattr attr)
		{
		struct inode *inode = d_inode(entry);
		int ret;

		if (!fuse_allow_current_process(get_fuse_conn(inode)))
		return -EACCES;

		if (attr->ia_valid & ATTR_FILE)
		return fuse_do_setattr(inode, attr, attr->ia_file);
		ret = fuse_do_setattr(inode, attr, attr->ia_file);
		else
		return fuse_do_setattr(inode, attr, NULL);
		ret = fuse_do_setattr(inode, attr, NULL);

		if (!ret) {
		/* Directory mode changed, may need to revalidate access */
		if (d_is_dir(entry) && (attr->ia_valid & ATTR_MODE))
		fuse_invalidate_entry_cache(entry);
		}
		return ret;
		}

		static int fuse_getattr(struct vfsmount mnt, struct dentry entry,