Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 96b34040 authored by Salva Peiró's avatar Salva Peiró Committed by David S. Miller
Browse files

farsync: fix info leak in ioctl 



The fst_get_iface() code fails to initialize the two padding bytes of
struct sync_serial_settings after the ->loopback member. Add an explicit
memset(0) before filling the structure to avoid the info leak.

Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent bf581759

drivers/net/wan/farsync.c

+1 −0
Original line number Original line Diff line number Diff line
@@ -1972,6 +1972,7 @@ fst_get_iface(struct fst_card_info *card, struct fst_port_info *port, 
	}

	}





	i = port->index;

	i = port->index;

	memset(&sync, 0, sizeof(sync));

	sync.clock_rate = FST_RDL(card, portConfig[i].lineSpeed);

	sync.clock_rate = FST_RDL(card, portConfig[i].lineSpeed);

	/* Lucky card and linux use same encoding here */

	/* Lucky card and linux use same encoding here */

	sync.clock_type = FST_RDB(card, portConfig[i].internalClock) ==

	sync.clock_type = FST_RDB(card, portConfig[i].internalClock) ==