Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9452bf56 authored by Larry Finger's avatar Larry Finger Committed by Greg Kroah-Hartman
Browse files

staging: r8188eu: Calling rtw_get_stainfo() with a NULL sta_addr will return NULL 



This makes the follow-on check for psta != NULL pointless and makes
the whole exercise rather pointless. This is another case of why
blindly zero-initializing variables when they are declared is bad.

Reported-by: default avatarJes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: default avatarLarry Finger <Larry.Finger@lwfinger.net>
Cc: Stable <stable@vger.kernel.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent b34aa86f

drivers/staging/rtl8188eu/core/rtw_recv.c

+2 −2
Original line number Diff line number Diff line
@@ -545,7 +545,7 @@ static struct recv_frame *decryptor(struct adapter *padapter, 
static struct recv_frame *portctrl(struct adapter *adapter,

				   struct recv_frame *precv_frame)

{

	u8   *psta_addr = NULL, *ptr;

	u8   *psta_addr, *ptr;

	uint  auth_alg;

	struct recv_frame *pfhdr;

	struct sta_info *psta;
@@ -558,7 +558,6 @@ static struct recv_frame *portctrl(struct adapter *adapter, 




	pstapriv = &adapter->stapriv;

	psta = rtw_get_stainfo(pstapriv, psta_addr);



	auth_alg = adapter->securitypriv.dot11AuthAlgrthm;
@@ -566,6 +565,7 @@ static struct recv_frame *portctrl(struct adapter *adapter, 
	pfhdr = precv_frame;

	pattrib = &pfhdr->attrib;

	psta_addr = pattrib->ta;

	psta = rtw_get_stainfo(pstapriv, psta_addr);



	prtnframe = NULL;