Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 92875d96 authored by Maulik Shah's avatar Maulik Shah
Browse files

drivers: soc: qcom: rpm_stats: Fix uninitialized buffer usage



Add matching else case to fix uninitialized buffer usage in
case of version id mismatch.

Change-Id: I7140692f62760d8f0e38f1cde4e3f9ce91a263f4
Signed-off-by: default avatarMaulik Shah <mkshah@codeaurora.org>
parent 8f672181
Loading
Loading
Loading
Loading
+5 −2
Original line number Diff line number Diff line
/* Copyright (c) 2011-2017, The Linux Foundation. All rights reserved.
/* Copyright (c) 2011-2017, 2019, The Linux Foundation. All rights reserved.
 *
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License version 2 and
@@ -389,7 +389,7 @@ static ssize_t rpmstats_show(struct kobject *kobj,
{
	struct msm_rpmstats_private_data *prvdata = NULL;
	struct msm_rpmstats_platform_data *pdata = NULL;
	ssize_t ret;
	ssize_t ret = 0;

	mutex_lock(&rpm_stats_mutex);
	pdata = GET_PDATA_OF_ATTR(attr);
@@ -428,9 +428,12 @@ static ssize_t rpmstats_show(struct kobject *kobj,
		else if (prvdata->platform_data->version == 2)
			prvdata->len = msm_rpmstats_copy_stats_v2(
					prvdata);
		else
			goto exit;
	}

	ret = snprintf(buf, prvdata->len, "%s", prvdata->buf);
exit:
	iounmap(prvdata->reg_base);
ioremap_fail:
	kfree(prvdata);