Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 915c420d authored by NeilBrown's avatar NeilBrown
Browse files

md/bitmap: be more consistent when setting new bits in memory bitmap. 



For each active region corresponding to a bit in the bitmap with have
a 14bit counter (and some flags).
This counts
   number of active writes + bit in the on-disk bitmap + delay-needed.

The "delay-needed" is because we always want a delay before clearing a
bit.  So the number here is normally number of active writes plus 2.
If there have been no writes for a while, we drop to 1.
If still no writes we clear the bit and drop to 0.

So for consistency, when setting bit from the on-disk bitmap or by
request from user-space it is best to set the counter to '2' to start
with.

In particular we might also set the NEEDED_MASK flag at this time, and
in all other cases NEEDED_MASK is only set when the counter is 2 or
more.

Signed-off-by: default avatarNeilBrown <neilb@suse.de>
parent 38059ec2

drivers/md/bitmap.c

+1 −1
Original line number Original line Diff line number Diff line
@@ -1587,7 +1587,7 @@ static void bitmap_set_memory_bits(struct bitmap *bitmap, sector_t offset, int n 
	}

	}

	if (!*bmc) {

	if (!*bmc) {

		struct page *page;

		struct page *page;

		*bmc = 1 | (needed ? NEEDED_MASK : 0);

		*bmc = 2 | (needed ? NEEDED_MASK : 0);

		bitmap_count_page(bitmap, offset, 1);

		bitmap_count_page(bitmap, offset, 1);

		page = filemap_get_page(bitmap, offset >> CHUNK_BLOCK_SHIFT(bitmap));

		page = filemap_get_page(bitmap, offset >> CHUNK_BLOCK_SHIFT(bitmap));

		set_page_attr(bitmap, page, BITMAP_PAGE_PENDING);

		set_page_attr(bitmap, page, BITMAP_PAGE_PENDING);