Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 906f1b29 authored by Subbaraman Narayanamurthy's avatar Subbaraman Narayanamurthy
Browse files

qpnp-fg-gen3: fix reading OCV and Vbatt predicted values 



Open circuit voltage and predicted battery voltage are read from
16 bits. However, the real value is present only in 15 bits.
Mask the bit 16 to get the proper readings.

Change-Id: I196ccc64fd221fead87a88f43dce1a21ba800908
Signed-off-by: default avatarSubbaraman Narayanamurthy <subbaram@codeaurora.org>
parent cdb65a95

drivers/power/qcom-charger/qpnp-fg-gen3.c

+17 −4
Original line number Diff line number Diff line
@@ -100,6 +100,8 @@ 
#define FLOAT_VOLT_v2_WORD		16

#define FLOAT_VOLT_v2_OFFSET		2



static int fg_decode_voltage_15b(struct fg_sram_param *sp,

	enum fg_sram_param_id id, int val);

static int fg_decode_value_16b(struct fg_sram_param *sp,

	enum fg_sram_param_id id, int val);

static int fg_decode_default(struct fg_sram_param *sp,
@@ -132,9 +134,9 @@ static struct fg_sram_param pmicobalt_v1_sram_params[] = { 
	PARAM(BATT_SOC, BATT_SOC_WORD, BATT_SOC_OFFSET, 4, 1, 1, 0, NULL,

		fg_decode_batt_soc),

	PARAM(VOLTAGE_PRED, VOLTAGE_PRED_WORD, VOLTAGE_PRED_OFFSET, 2, 244141,

		1000, 0, NULL, fg_decode_value_16b),

		1000, 0, NULL, fg_decode_voltage_15b),

	PARAM(OCV, OCV_WORD, OCV_OFFSET, 2, 244141, 1000, 0, NULL,

		fg_decode_value_16b),

		fg_decode_voltage_15b),

	PARAM(RSLOW, RSLOW_WORD, RSLOW_OFFSET, 2, 244141, 1000, 0, NULL,

		fg_decode_value_16b),

	PARAM(ALG_FLAGS, ALG_FLAGS_WORD, ALG_FLAGS_OFFSET, 1, 1, 1, 0, NULL,
@@ -178,9 +180,9 @@ static struct fg_sram_param pmicobalt_v2_sram_params[] = { 
	PARAM(BATT_SOC, BATT_SOC_WORD, BATT_SOC_OFFSET, 4, 1, 1, 0, NULL,

		fg_decode_batt_soc),

	PARAM(VOLTAGE_PRED, VOLTAGE_PRED_WORD, VOLTAGE_PRED_OFFSET, 2, 244141,

		1000, 0, NULL, fg_decode_value_16b),

		1000, 0, NULL, fg_decode_voltage_15b),

	PARAM(OCV, OCV_WORD, OCV_OFFSET, 2, 244141, 1000, 0, NULL,

		fg_decode_value_16b),

		fg_decode_voltage_15b),

	PARAM(RSLOW, RSLOW_WORD, RSLOW_OFFSET, 2, 244141, 1000, 0, NULL,

		fg_decode_value_16b),

	PARAM(ALG_FLAGS, ALG_FLAGS_WORD, ALG_FLAGS_OFFSET, 1, 1, 1, 0, NULL,
@@ -303,6 +305,17 @@ static int fg_restart; 


/* All getters HERE */



#define VOLTAGE_15BIT_MASK	GENMASK(14, 0)

static int fg_decode_voltage_15b(struct fg_sram_param *sp,

				enum fg_sram_param_id id, int value)

{

	value &= VOLTAGE_15BIT_MASK;

	sp[id].value = div_u64((u64)value * sp[id].numrtr, sp[id].denmtr);

	pr_debug("id: %d raw value: %x decoded value: %x\n", id, value,

		sp[id].value);

	return sp[id].value;

}



static int fg_decode_cc_soc(struct fg_sram_param *sp,

				enum fg_sram_param_id id, int value)

{