Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8d532b2a authored by Chris Mason's avatar Chris Mason
Browse files

Btrfs: fix worker lock misuse in find_worker 



Dan Carpenter noticed that we were doing a double unlock on the worker
lock, and sometimes picking a worker thread without the lock held.

This fixes both errors.

Signed-off-by: default avatarChris Mason <chris.mason@oracle.com>
Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
parent d85c8a6f

fs/btrfs/async-thread.c

+2 −1
Original line number Diff line number Diff line
@@ -563,8 +563,8 @@ static struct btrfs_worker_thread *find_worker(struct btrfs_workers *workers) 
	struct list_head *fallback;

	int ret;



again:

	spin_lock_irqsave(&workers->lock, flags);

again:

	worker = next_worker(workers);



	if (!worker) {
@@ -579,6 +579,7 @@ again: 
			spin_unlock_irqrestore(&workers->lock, flags);

			/* we're below the limit, start another worker */

			ret = __btrfs_start_workers(workers);

			spin_lock_irqsave(&workers->lock, flags);

			if (ret)

				goto fallback;

			goto again;