Commit 8cade52f authored Mar 15, 2021 by Tong Zhang Committed by Greg Kroah-Hartman Apr 07, 2021

staging: comedi: cb_pcidas: fix request_irq() warn



[ Upstream commit 2e5848a3d86f03024ae096478bdb892ab3d79131 ]

request_irq() wont accept a name which contains slash so we need to
repalce it with something else -- otherwise it will trigger a warning
and the entry in /proc/irq/ will not be created
since the .name might be used by userspace and we don't want to break
userspace, so we are changing the parameters passed to request_irq()

[    1.630764] name 'pci-das1602/16'
[    1.630950] WARNING: CPU: 0 PID: 181 at fs/proc/generic.c:180 __xlate_proc_name+0x93/0xb0
[    1.634009] RIP: 0010:__xlate_proc_name+0x93/0xb0
[    1.639441] Call Trace:
[    1.639976]  proc_mkdir+0x18/0x20
[    1.641946]  request_threaded_irq+0xfe/0x160
[    1.642186]  cb_pcidas_auto_attach+0xf4/0x610 [cb_pcidas]

Suggested-by: Ian Abbott <abbotti@mev.co.uk>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Tong Zhang <ztong0001@gmail.com>
Link: https://lore.kernel.org/r/20210315195914.4801-1-ztong0001@gmail.com


Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 862caeb2

drivers/staging/comedi/drivers/cb_pcidas.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -1290,7 +1290,7 @@ static int cb_pcidas_auto_attach(struct comedi_device *dev,
	devpriv->amcc + AMCC_OP_REG_INTCSR);		devpriv->amcc + AMCC_OP_REG_INTCSR);

	ret = request_irq(pcidev->irq, cb_pcidas_interrupt, IRQF_SHARED,		ret = request_irq(pcidev->irq, cb_pcidas_interrupt, IRQF_SHARED,
	dev->board_name, dev);		"cb_pcidas", dev);
	if (ret) {		if (ret) {
	dev_dbg(dev->class_dev, "unable to allocate irq %d\n",		dev_dbg(dev->class_dev, "unable to allocate irq %d\n",
	pcidev->irq);		pcidev->irq);