Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 893134b0 authored by Dan Carpenter's avatar Dan Carpenter Committed by Greg Kroah-Hartman
Browse files

staging: r8188eu: array overflow in rtw_mp_ioctl_hdl() 



MAX_MP_IOCTL_SUBCODE (35) and mp_ioctl_hdl (32 elements) are no longer
in sync.  It leads to a bogus pointer dereference.

Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Acked-by: default avatarLarry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 08951f10

drivers/staging/rtl8188eu/os_dep/ioctl_linux.c

+1 −1
Original line number Diff line number Diff line
@@ -2500,7 +2500,7 @@ static int rtw_mp_ioctl_hdl(struct net_device *dev, struct iw_request_info *info 
		 ("rtw_mp_ioctl_hdl: subcode [%d], len[%d], buffer_len[%d]\r\n",

		  poidparam->subcode, poidparam->len, len));



	if (poidparam->subcode >= MAX_MP_IOCTL_SUBCODE) {

	if (poidparam->subcode >= ARRAY_SIZE(mp_ioctl_hdl)) {

		RT_TRACE(_module_rtl871x_ioctl_os_c, _drv_err_, ("no matching drvext subcodes\r\n"));

		ret = -EINVAL;

		goto _rtw_mp_ioctl_hdl_exit;