Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 87a875bb authored by Daniel Vetter's avatar Daniel Vetter
Browse files

drm/i915: WARN on lack of shared dpll 



Now that we have proper hw state reconstruction we should never have a
case where we don't have the software dpll state properly set up. So
add WARNs to the respective !pll cases in enable/disabel_shared_dpll.

Reviewed-by: default avatarDamien Lespiau <damien.lespiau@intel.com>
Signed-off-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
parent 91d1b4bd

drivers/gpu/drm/i915/intel_display.c

+2 −2
Original line number Diff line number Diff line
@@ -1401,7 +1401,7 @@ static void ironlake_enable_shared_dpll(struct intel_crtc *crtc) 


	/* PCH PLLs only available on ILK, SNB and IVB */

	BUG_ON(dev_priv->info->gen < 5);

	if (pll == NULL)

	if (WARN_ON(pll == NULL))

		return;



	if (WARN_ON(pll->refcount == 0))
@@ -1430,7 +1430,7 @@ static void intel_disable_shared_dpll(struct intel_crtc *crtc) 


	/* PCH only available on ILK+ */

	BUG_ON(dev_priv->info->gen < 5);

	if (pll == NULL)

	if (WARN_ON(pll == NULL))

	       return;



	if (WARN_ON(pll->refcount == 0))