Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 86974bff authored by Emmanuel Grumbach's avatar Emmanuel Grumbach
Browse files

iwlwifi: mvm: fix endianity issues with Smart Fifo commands 



This code was broken on big endian systems. Sparse didn't
catch the bug since the firmware command was not tagged as
little endian.
Fix the bug for big endian systems and tag the field in the
firmware command to prevent such issues in the future.

Cc: stable@vger.kernel.org [3.14+]
Fixes: 1f3b0ff8 ("iwlwifi: mvm: Add Smart FIFO support")
Reviewed-by: default avatarJohannes Berg <johannes.berg@intel.com>
Signed-off-by: default avatarEmmanuel Grumbach <emmanuel.grumbach@intel.com>
parent 7c8b3bc6

drivers/net/wireless/iwlwifi/mvm/fw-api.h

+2 −2
Original line number Diff line number Diff line
@@ -1563,14 +1563,14 @@ enum iwl_sf_scenario { 


/**

 * Smart Fifo configuration command.

 * @state: smart fifo state, types listed in iwl_sf_sate.

 * @state: smart fifo state, types listed in enum %iwl_sf_sate.

 * @watermark: Minimum allowed availabe free space in RXF for transient state.

 * @long_delay_timeouts: aging and idle timer values for each scenario

 * in long delay state.

 * @full_on_timeouts: timer values for each scenario in full on state.

 */

struct iwl_sf_cfg_cmd {

	enum iwl_sf_state state;

	__le32 state;

	__le32 watermark[SF_TRANSIENT_STATES_NUMBER];

	__le32 long_delay_timeouts[SF_NUM_SCENARIO][SF_NUM_TIMEOUT_TYPES];

	__le32 full_on_timeouts[SF_NUM_SCENARIO][SF_NUM_TIMEOUT_TYPES];

drivers/net/wireless/iwlwifi/mvm/sf.c

+1 −1
Original line number Diff line number Diff line
@@ -172,7 +172,7 @@ static int iwl_mvm_sf_config(struct iwl_mvm *mvm, u8 sta_id, 
			     enum iwl_sf_state new_state)

{

	struct iwl_sf_cfg_cmd sf_cmd = {

		.state = new_state,

		.state = cpu_to_le32(new_state),

	};

	struct ieee80211_sta *sta;

	int ret = 0;