Commit 835fe63d authored Jun 01, 2021 by Jiapeng Chong Committed by Greg Kroah-Hartman Jul 20, 2021

RDMA/cxgb4: Fix missing error code in create_qp()

[ Upstream commit aeb27bb76ad8197eb47890b1ff470d5faf8ec9a5 ]

The error code is missing in this code scenario so 0 will be returned. Add
the error code '-EINVAL' to the return value 'ret'.

Eliminates the follow smatch warning:

drivers/infiniband/hw/cxgb4/qp.c:298 create_qp() warn: missing error code 'ret'.

Link: https://lore.kernel.org/r/1622545669-20625-1-git-send-email-jiapeng.chong@linux.alibaba.com


Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent c43fa9ee

drivers/infiniband/hw/cxgb4/qp.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -277,6 +277,7 @@ static int create_qp(struct c4iw_rdev rdev, struct t4_wq wq,
		if (user && (!wq->sq.bar2_pa \|\| !wq->rq.bar2_pa)) {
		pr_warn(MOD "%s: sqid %u or rqid %u not in BAR2 range.\n",
		pci_name(rdev->lldi.pdev), wq->sq.qid, wq->rq.qid);
		ret = -EINVAL;
		goto free_dma;
		}