Commit 7d82bf34 authored Jan 12, 2015 by Geert Uytterhoeven Committed by Linus Walleij Jan 15, 2015

gpio: rcar: Fix error path for devm_kzalloc() failure



If the call to devm_kzalloc() fails, nothing must be cleant up.
This was missed before because gpio_rcar_probe() had a "return"
statement after the first "goto err0".

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Fixes: df0c6c80 ("gpio: rcar: Add minimal runtime PM support")
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

parent f1d2d081

drivers/gpio/gpio-rcar.c

+2 −4

Original line number	Diff line number	Diff line
		@@ -372,10 +372,8 @@ static int gpio_rcar_probe(struct platform_device *pdev)
		int ret;

		p = devm_kzalloc(dev, sizeof(*p), GFP_KERNEL);
		if (!p) {
		ret = -ENOMEM;
		goto err0;
		}
		if (!p)
		return -ENOMEM;

		p->pdev = pdev;
		spin_lock_init(&p->lock);