Commit 7c573f32 authored Dec 24, 2021 by Tom Rix Committed by Greg Kroah-Hartman Jan 05, 2022

selinux: initialize proto variable in selinux_ip_postroute_compat()



commit 732bc2ff080c447f8524f40c970c481f5da6eed3 upstream.

Clang static analysis reports this warning

hooks.c:5765:6: warning: 4th function call argument is an uninitialized
                value
        if (selinux_xfrm_postroute_last(sksec->sid, skb, &ad, proto))
            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

selinux_parse_skb() can return ok without setting proto.  The later call
to selinux_xfrm_postroute_last() does an early check of proto and can
return ok if the garbage proto value matches.  So initialize proto.

Cc: stable@vger.kernel.org
Fixes: eef9b416 ("selinux: cleanup selinux_xfrm_sock_rcv_skb() and selinux_xfrm_postroute_last()")
Signed-off-by: Tom Rix <trix@redhat.com>
[PM: typo/spelling and checkpatch.pl description fixes]
Signed-off-by: Paul Moore <paul@paul-moore.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 11ade93f

security/selinux/hooks.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -4974,7 +4974,7 @@ static unsigned int selinux_ip_postroute_compat(struct sk_buff *skb,
	struct common_audit_data ad;		struct common_audit_data ad;
	struct lsm_network_audit net = {0,};		struct lsm_network_audit net = {0,};
	char *addrp;		char *addrp;
	u8 proto;		u8 proto = 0;

	if (sk == NULL)		if (sk == NULL)
	return NF_ACCEPT;		return NF_ACCEPT;