Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7b8aca65 authored by Lee, Chun-Yi's avatar Lee, Chun-Yi Committed by Matthew Garrett
Browse files

acer-wmi: schedule threeg and interface sysfs for feature removal 



we can now autodetect internal 3G device and already have the threeg
rfkill device. So, we plan to remove threeg sysfs support for it's no
longer necessary.

We also plan to remove interface sysfs file that exposed which ACPI-WMI
interface that was used by acer-wmi driver. It will replaced by information
log when acer-wmi initial.

We keep it around for userspace compatibility reasons, schedule removal
in 2012.

Cc: Carlos Corbacho <carlos@strangeworlds.co.uk>
Cc: Matthew Garrett <mjg@redhat.com>
Cc: Dmitry Torokhov <dtor@mail.ru>
Cc: Corentin Chary <corentincj@iksaif.net>
Acked-by: default avatarThomas Renninger <trenn@suse.de>
Signed-off-by: default avatarLee, Chun-Yi <jlee@novell.com>
Signed-off-by: default avatarMatthew Garrett <mjg@redhat.com>
parent de96355c

Documentation/feature-removal-schedule.txt

+11 −0
Original line number Diff line number Diff line
@@ -581,3 +581,14 @@ Why: This driver has been superseded by g_mass_storage. 
Who:	Alan Stern <stern@rowland.harvard.edu>



----------------------------



What:   threeg and interface sysfs files in /sys/devices/platform/acer-wmi

When:   2012

Why:    In 3.0, we can now autodetect internal 3G device and already have

	the threeg rfkill device. So, we plan to remove threeg sysfs support

	for it's no longer necessary.



	We also plan to remove interface sysfs file that exposed which ACPI-WMI

	interface that was used by acer-wmi driver. It will replaced by

	information log when acer-wmi initial.

Who:    Lee, Chun-Yi <jlee@novell.com>

drivers/platform/x86/acer-wmi.c

+9 −2
Original line number Diff line number Diff line
@@ -1400,6 +1400,9 @@ static ssize_t show_bool_threeg(struct device *dev, 
{

	u32 result; \

	acpi_status status;



	pr_info("This threeg sysfs will be removed in 2012"

		" - used by: %s\n", current->comm);

	if (wmi_has_guid(WMID_GUID3))

		status = wmid3_get_device_status(&result,

				ACER_WMID3_GDS_THREEG);
@@ -1415,6 +1418,8 @@ static ssize_t set_bool_threeg(struct device *dev, 
{

	u32 tmp = simple_strtoul(buf, NULL, 10);

	acpi_status status = set_u32(tmp, ACER_CAP_THREEG);

	pr_info("This threeg sysfs will be removed in 2012"

		" - used by: %s\n", current->comm);

	if (ACPI_FAILURE(status))

		return -EINVAL;

	return count;
@@ -1425,6 +1430,8 @@ static DEVICE_ATTR(threeg, S_IRUGO | S_IWUSR, show_bool_threeg, 
static ssize_t show_interface(struct device *dev, struct device_attribute *attr,

	char *buf)

{

	pr_info("This interface sysfs will be removed in 2012"

		" - used by: %s\n", current->comm);

	switch (interface->type) {

	case ACER_AMW0:

		return sprintf(buf, "AMW0\n");